Quantcast
Channel: Wireless Connectivity
Viewing all articles
Browse latest Browse all 116964

Forum Post: SimpliciTI 1.2.0 stalls in mrfi_radio.c

$
0
0

Hello,

I have been running several different releases of SimpliciTI on CC2530 during the past few years, and with no modifications to them, my code has always occasionally stalled on the following line (#1087) in Components/mrfi/radios/family6/mrfi_radio.c:

while(!(RFIRQF0 & IRQ_FIFOP));

I have usually quickly fixed it by removing line 1098 (resetting the flag with " &= ~ " ) altogether because it seems that the non-atomic statement can go wrong and should be replaced with something better. Plus that at the end of the ISR the same flag is reset anyway. Now that this fix is still needed in the latest release (1.2.0) I thought I'd better ask others if I'm doing something wrong or if TI should fix something in their code?

Another thing that worries me is around line 1122 in the same file where the FIFO is supposed to be discarded. There is however no read instruction involved, just a stale line "RFD;" which the compiler obviously throws away. I have usually replaced this with something like "volatile uint8_t trash_bin = RFD;". Comments?

-Ville


Viewing all articles
Browse latest Browse all 116964

Trending Articles



<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>